This repository has been archived by the owner on Jun 12, 2020. It is now read-only.
Adds tests for Codable #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbs
commented
Jun 9, 2017
README.md
Outdated
| @@ -217,6 +217,7 @@ JSONCodable | 4.363 sec | 0.510 sec | |||
| Unbox | 3.102 sec | 0.372 sec | |||
| Decodable | 1.642 sec | 0.215 sec | |||
| Marshal | 0.528 sec | 0.096 sec | |||
| Codable | 1.233 sec | 0.204 sec | |||
There was a problem hiding this comment.
These numbers were obtained from running the tests on an iPhone 6S.
|
Naturally these numbers are obtained using Xcode 9 beta 1, so it may be worth to run the tests again during and after the beta to ensure that they are up to date. |
|
First of all, thanks for the PR! 🎉 It's worth noting that this change also changes the Swift version of these tests to Swift 4. We haven't yet looked into what are the consequences of upgrading our frameworks/repos to Swift 4, although I am pretty sure this repository would be the one least affected. 😄 For now, I'll leave the PR open and either merge it in soon, or wait until there's a release version of Xcode. Thanks again 👏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for parsing and mapping using Apples JSON decoder and Codable protocol. The tests were run on an iPhone 6S.