Add mlkem768x25519 Kex as per draft-kampanakis-curdle-ssh-pq-ke #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original libcrux code was taken from OpenSSH with suitable modifications done by us. Interop testing done with OpenSSH client. Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Jaykishan Mutkawoa <[email protected]> Signed-off-by: Kavish Nadan <[email protected]>
mkj
reviewed
Jan 13, 2025
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Jaykishan Mutkawoa <[email protected]> Signed-off-by: Kavish nadan <[email protected]>
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Jaykishan Mutkawoa <[email protected]> Signed-off-by: Kavish Nadan <[email protected]>
loganaden
changed the title
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Jaykishan Mutkawoa <[email protected]> Signed-off-by: Kavish Nadan <[email protected]>
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Jaykishan Mutkawoa <[email protected]> Signed-off-by: Kavish Nadan <[email protected]>
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Jaykishan Mutkawoa <[email protected]> Signed-off-by: Kavish Nadan <[email protected]>
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Jaykishan Mutkawoa <[email protected]> Signed-off-by: Kavish nadan <[email protected]>
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Jaykishan Mutkawoa <[email protected]> Signed-off-by: Kavish nadan <[email protected]>
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Jaykishan Mutkawoa <[email protected]> Signed-off-by: Kavish nadan <[email protected]>
|
@mkj removed a couple of warnings for libcrux, but it's still causing build failures. Any suggestion ? |
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Jaykishan Mutkawoa <[email protected]> Signed-off-by: Kavish nadan <[email protected]>
Signed-off-by: Loganaden Velvindron <[email protected]> Signed-off-by: Jaykishan Mutkawoa <[email protected]> Signed-off-by: Kavish Nadan <[email protected]>
|
@mkj disabled MLKEM768 for c89 and ignore another warning for libcrux. Any advice on going further ? |
|
Disabling the c89 check makes sense. I'll have a look when I get a chance during the next week.
…On 18 January 2025 9:34:07 pm ACDT, Loganaden Velvindron ***@***.***> wrote:
@mkj disabled MLKEM768 for c89 and ignore another warning for libcrux.
Any advice on going further ?
--
Reply to this email directly or view it on GitHub:
#342 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
|
I've made some changes in https://github.com/mkj/dropbear/tree/dev/matt/mlkem to get it working. I'll give it a bit more testing and add some fuzzing before squashing to merge. |
|
@mkj we have a PR for fuzzing. Can we send it to your branch ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original libcrux code was taken from OpenSSH with suitable modifications done by us.
Interop testing done with OpenSSH client.