Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -S option for TCP Socket keepalives and -n option to disable compression #100

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

brentr
Copy link

@brentr brentr commented May 30, 2020

The -S option takes an optional numeric suffix to override the TCP_KEEPIDLE timeout.
If combined with -K, the TCP_KEEPIDLE is set to 3*the SSH keep alive time
The intent is to have socket keepalives start when the session keep alives end.
The socket keepalives ensure that the session WILL eventually detect a dead peer, even it that peer dies during authentication.
We recently had such a case on a remotely deployed system -- a couple miles off the coast of Denmark.
The changes to option parsing are extensive, but I tried to keep with the spirit of what was there.
Why didn't you use get_opt?

@mkj
Copy link
Owner

mkj commented Jun 9, 2020

Hi,

I think it might make more sense to have just -o TCPKeepAlive=yes and -o compression=no? That shouldn't need to change parsing much and is compatible with openssh's client.

I can't remember why I didn't use getopt (it was 15 years ago), possibly it didn't work on some platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants