Use Conts file for some constant values

miyurud · Jan 13, 2025 · 7051494 · 7051494
1 parent 92b12f1
commit 7051494
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/src/frontend/JasmineGraphFrontEnd.cpp b/src/frontend/JasmineGraphFrontEnd.cpp
@@ -1279,14 +1279,14 @@ static void add_stream_kafka_command(int connFd, std::string &kafka_server_IP, c
         *loop_exit_p = true;
         return;
     }
-    result_wr = write(connFd, "\r\n", 2);
+    result_wr = write(connFd, Conts::CARRIAGE_RETURN_NEW_LINE.c_str(), Conts::CARRIAGE_RETURN_NEW_LINE.size());
     if (result_wr < 0) {
         frontend_logger.error("Error writing to socket");
         *loop_exit_p = true;
         return;
     }
-    string msg_2 = "Is this graph Directed (y/n)? ";
-    result_wr = write(connFd, msg_2.c_str(), msg_2.length());
+    string checkDirection = "Is this graph Directed (y/n)? ";
+    result_wr = write(connFd, checkDirection.c_str(), checkDirection.length());
     if (result_wr < 0) {
         frontend_logger.error("Error writing to socket");
         *loop_exit_p = true;
@@ -1303,20 +1303,20 @@ static void add_stream_kafka_command(int connFd, std::string &kafka_server_IP, c
     }
     string direction;
     if (is_directed == "y") {
-        direction = "1";
+        direction = Conts::DIRECTED;
     } else {
-        direction = "0";
+        direction = Conts::UNDIRECTED;
     }
 
-    string msg_3 = "Graph type received";
-    result_wr = write(connFd, msg_3.c_str(), msg_3.length());
+    string checkGraphType = "Graph type received";
+    result_wr = write(connFd, checkGraphType.c_str(), checkGraphType.length());
     if (result_wr < 0) {
         frontend_logger.error("Error writing to socket");
         *loop_exit_p = true;
         return;
     }
 
-    result_wr = write(connFd, "\r\n", 2);
+    result_wr = write(connFd, Conts::CARRIAGE_RETURN_NEW_LINE.c_str(), Conts::CARRIAGE_RETURN_NEW_LINE.size());
     if (result_wr < 0) {
         frontend_logger.error("Error writing to socket");
         *loop_exit_p = true;

diff --git a/src/util/Conts.cpp b/src/util/Conts.cpp
@@ -15,7 +15,8 @@ limitations under the License.
 
 std::string Conts::JASMINEGRAPH_EXECUTABLE = "run.sh";
 std::string Conts::JASMINEGRAPH_HOME = "JASMINEGRAPH_HOME";
-
+std::string Conts::DIRECTED = "1";
+std::string Conts::UNDIRECTED = "0";
 std::string Conts::CARRIAGE_RETURN_NEW_LINE = "\r\n";
 
 std::string Conts::GRAPH_TYPE_RDF = "RDF_GRAPH";

diff --git a/src/util/Conts.h b/src/util/Conts.h
@@ -66,7 +66,8 @@ class Conts {
     static std::string GRAPH_WITH_TEXT_ATTRIBUTES;
     static std::string GRAPH_WITH_JSON_ATTRIBUTES;
     static std::string GRAPH_WITH_XML_ATTRIBUTES;
-
+    static std::string DIRECTED;
+    static std::string UNDIRECTED;
     static std::string CARRIAGE_RETURN_NEW_LINE;
 
     static std::string