Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC7000: Fix code style issues in the controller script #4754

Closed
wants to merge 1 commit into from

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented May 12, 2022

There are a bunch of style issues in the script that the pre-commit hook didn't accept, mostly regarding const/let declarations of variables.

@fwcd fwcd force-pushed the fix-mc7000-style-issues branch from 1405533 to 4cf08da Compare May 12, 2022 01:09
@fwcd fwcd marked this pull request as draft May 12, 2022 01:10
@fwcd fwcd marked this pull request as ready for review May 12, 2022 01:24
@toszlanyi
Copy link
Contributor

Const/let its not working with the current releases of Mixxx, only for the future. So all your improvements will not be able to run on current release. Just my thought but I guess, the shift and jog acceleration should go first, so based to 2.3 branch and the const/let change to 2.4 or main branch. Maybe @Swiftb0y can comment better on this topic. Cheers

@uklotzde
Copy link
Contributor

Fixing the ES6 linter issues on main should be deferred until no more 2.3.x releases are expected. Otherwise this would cause serious merge conflicts when improvements or fixes for 2.3.x mappings are provided. In this case #4729 would be affected.

@github-actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Aug 12, 2022
@JoergAtGithub JoergAtGithub added this to the 2.4.0 milestone Jul 15, 2023
@github-actions github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Aug 26, 2023
@fwcd
Copy link
Member Author

fwcd commented Oct 22, 2023

Looks like the 2.3 merges (e.g. 17f3c42 and 302b40e) already took care of everything in this PR (I think the code style changes were introduced during these merges since I couldn't find more granular commits).

@fwcd fwcd closed this Oct 22, 2023
@fwcd fwcd deleted the fix-mc7000-style-issues branch October 22, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants