-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Osc in mixxx -> /Tree/Banch/Leaf -> experimental #14238
Open
Eve00000
wants to merge
22
commits into
mixxxdj:main
Choose a base branch
from
Eve00000:OSC_in_Mixxx_TreeBranchLeaf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eve00000
changed the title
Osc in mixxx -> Tree\Banch\Leaf -> experimental
Osc in mixxx -> /Tree/Banch/Leaf -> experimental
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows the logic of discussion / reasoning with @daschuer
links to pr #14229
Stepping up from OSC with an eye on the future, preparing for url-based commands.
This pr is the new form of OSC in Mixxx based on previous OSC which use # and @ symbols to translate Osc to Mixxx-CO's,
in this PR the OSC-addresses are allin the \tree\branch\leaf - format.
prepared for /cov and /cop (and /cot) but not yet implemented (except in scripts)
copied the get logic from
/GetP# becomes /Get/cop
/GetV# becomes /Get/cov
/GeTP# becomes /Get/cot
Also with a new MixxxInTouch version with cov cop and /tree/branch/leaf
there could still be some errors.
MixxxInTouchOSCv50 COV COP.tosc.txt