make passthrough / vinylcontrol_enabled exclusive
#14237
Conversation
when enabling one or the other, the respective other control is toggled off Enabling Passthrough stops the deck so VC has nothing to do anyway. Furthermore, this disables the VC signal quality display in the spinnies with Passthrough
|
Does the current state introduce any issues? I'm wondering because maybe some people use this behavior to use a vinyl track in their set and then continue with VC without having to re-enable it again. I think this change, because it makes sense, but I wonder if we should remember the state before enabling pass-through and the switch VC back on automatically? |
Nope, except the noise of VC signal renderer. However, if users
they'd now have to re-enable it again. (there are VC hotkeys Ctrl+T/Y/U/I though) The other way around, if they have VC enable mapped they now don't have to click passthrough in the GUI anymore when switching back to VC : ) |
turn VC on -> passthrough off
turn passthrough on -> VC off
Passthrough stops the deck and then VC has nothing to do anyway.
And with passthrough it makes no sense to show the VC signal quality in the spinnies.
So basically this is just a small usability improvement with no harm. Or did I overlook something?
(one step to fix #14236)