preroll waveformrenderer using rendergraph #14190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolombier
approved these changes
Jan 19, 2025
10 tasks
qstringliteral Co-authored-by: Antoine Colombier <[email protected]>
qstringliteral Co-authored-by: Antoine Colombier <[email protected]>
qstringliteral Co-authored-by: Antoine Colombier <[email protected]>
qstringliteral Co-authored-by: Antoine Colombier <[email protected]>
Swiftb0y
reviewed
Jan 22, 2025
Comment on lines
-23
to
+24
| QImage image(imagePixelW, imagePixelH, QImage::Format_ARGB32_Premultiplied); | ||
| QImage image(imagePixelW, imagePixelH, QImage::Format_RGBA8888_Premultiplied); |
There was a problem hiding this comment.
can you quickly explain your rationale behind this?
According to the QImage docs:
Note: Avoid most rendering directly to most of these formats using QPainter. Rendering is best optimized to the Format_RGB32 and Format_ARGB32_Premultiplied formats, and secondarily for rendering to the Format_RGB16, Format_RGBX8888, Format_RGBA8888_Premultiplied, Format_RGBX64 and Format_RGBA64_Premultiplied formats
Comment on lines
+154
to
+156
| dynamic_cast<PatternMaterial&>(material()) | ||
| .setTexture(std::make_unique<Texture>(m_waveformRenderer->getContext(), | ||
| drawPrerollImage(m_markerLength, |
There was a problem hiding this comment.
does this allocate continuously in the hot paintGL path?
Comment on lines
+126
to
+127
| const int reserved = (preRollVisible ? numVerticesPerRectangle : 0) + | ||
| (postRollVisible ? numVerticesPerRectangle : 0); |
There was a problem hiding this comment.
does it make sense to move closer to the first use? and potentially give it a better name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the preroll waveformrenderer to a rendergraph node. This can be reviewed and merged independently from the PRs for the other waveformrenderers.