markrange waveformrenderer using rendergraph #14189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolombier
requested changes
Jan 19, 2025
10 tasks
|
I can't reproduce this, @acolombier , but it also don't see how this could be caused by this PR. If you set loop points, the range is drawn exactly where you set it, right? And if you close the track and re-open it, the range is where you expect it? If this is the case, the range code is working. The fact that your play position goes beyond. the end marker must be something else. Is it only visual or also audible? |
|
It could also be that the visual playposition is wrong. The related code to determine it is here: VisualPlayPosition::determinePlayPosInLoopBoundries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the markrange waveformrenderer to a rendergraph node. This can be reviewed and merged independently from the PRs for the other waveformrenderers.