mark waveformrenderer using rendergraph #14188
Conversation
|
|
||
| // Render digits using a texture (generated) with digits with blurred dark outline | ||
|
|
||
| using namespace rendergraph; | ||
|
|
||
| namespace { | ||
|
|
||
| // The texture will contain 12 characters: 10 digits, colon and dot |
There was a problem hiding this comment.
| // The texture will contain 12 characters: 10 digits, colon and dot | |
| /// The texture will contain 12 characters: 10 digits, colon and dot |
And elsewhere, so that it gets picked up by doxygen and IDEs.
There was a problem hiding this comment.
Is there a clear policy on this? IMO this is just a comment to help understand the code, not really API doc.
There was a problem hiding this comment.
I mean we don't really do API docs because we don't give any stability guarantees.
We don't really have a policy but some time ago we said that we try to use triple slash where it makes sense (i.e. if we add comments to classes, functions or constants). That makes the comment accessible to IDEs/LSP and people can see it when hovering over a method/constant, so that they have the explanation at hand instead of having to scroll to the definition.
Just to clarify: we said that we don't want the full-blown @param syntax (also hard to maintain), just that we add an additional slash so that we get IDE support for free.
There was a problem hiding this comment.
Ok. I prefer to do a follow-up PR to review all allshader code and change to /// where appropriate.
| #include "rendergraph/context.h" | ||
| #include "rendergraph/geometry.h" | ||
| #include "rendergraph/material/texturematerial.h" | ||
| #include "rendergraph/vertexupdaters/texturedvertexupdater.h" |
There was a problem hiding this comment.
These should be before the util includes.
|
A conflict has developed following the merge of the markrange support |
Yup, this one was expected :-) Fixed! I think this can be merged. |
Ports the mark waveformrenderer to a rendergraph node. This can be reviewed and merged independently from the PRs for the other waveformrenderers.