ControllerScriptInterfaceLegacy: Windows 1252 fix #14108
Merged
+104
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is intentional, we grouped all charsets that are full subsets of other charsets to the superset. This is described in the documentation, which you didn't change in this PR btw.: mixxx/res/controllers/engine-api.d.ts Line 317 in 436aa3c |
Swiftb0y
requested changes
Jan 2, 2025
src/controllers/scripting/legacy/controllerscriptinterfacelegacy.cpp
Outdated
Show resolved
Hide resolved
Ah, I understand. Than the Enum name was only misleading. I stumbled over this because "ASCII" and ""windows-1252" is not available without ICU or QT < 6.4. |
|
Done |
JoergAtGithub
previously requested changes
Jan 10, 2025
There was a problem hiding this comment.
If you change the enum, you need to change the typescript declaration as well: mixxx/res/controllers/engine-api.d.ts
|
Done |
|
@Swiftb0y Can we merge this now? |
Swiftb0y
approved these changes
Jan 30, 2025
Comment on lines
814
to
815
| auto result = qjsvalue_cast<QByteArray>(evaluate(source)); | ||
| qDebug() << result; | ||
| EXPECT_EQ(result.size(), convertedCharsetForString(enumValue)) |
daschuer
force-pushed
the
windows-1252-fix
branch
from
e40a477 to
3831d3d
Compare
|
Done and sqashed fixup. Reday for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latin1 is not Windows Western Europe charset. The later contains ™ and some other characters. This PR introduces both, "windows-1252" and "ISO-8859-1"
In addition this has some refactoring regarding string handling and makes the test pass on Qt 6.2 (I have not updated my dev machine to maintain the 2.5 branch)