Qt 6.8 deprecated declaration fixes #13845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
might be worth backporting to 2.5? |
Holzhaus
force-pushed
the
qt6.7-deprecated-decls
branch
from
5242673
to
b8125d5
Compare
Holzhaus
force-pushed
the
qt6.7-deprecated-decls
branch
from
8406d6b
to
78d41e6
Compare
Swiftb0y
reviewed
Nov 8, 2024
Holzhaus
force-pushed
the
qt6.7-deprecated-decls
branch
from
575dc5d
to
723f703
Compare
Fixes warnings such as:
mixxx/src/controllers/legacycontrollersettings.cpp: In member function ‘virtual QWidget* LegacyControllerBooleaetting::buildInputWidget(QWidget*)’:
mixxx/src/controllers/legacycontrollersettings.cpp:144:36: error: ‘void QCheckBox::stateChanged(int)’ is depreced: Use checkStateChanged() instead [-Werror=deprecated-declarations]
144 | connect(pCheckBox, &QCheckBox::stateChanged, this, [this](int state) {
| ^~~~~~~~~~~~
In file included from /usr/include/qt6/QtWidgets/QCheckBox:1,
from mixxx/src/controllers/legacycontrollersettings.cpp:5:/usr/include/qt6/QtWidgets/qcheckbox.h:41:10: note: declared here
41 | void stateChanged(int);
| ^~~~~~~~~~~~
cc1plus: all warnings being treated as errors
Holzhaus
force-pushed
the
qt6.7-deprecated-decls
branch
from
723f703
to
3767f3a
Compare
Holzhaus
force-pushed
the
qt6.7-deprecated-decls
branch
from
3767f3a
to
eec9ea4
Compare
Fixes warnings such as:
In file included from mixxx/src/library/browse/browsethread.cpp:10:
mixxx/src/util/datetime.h: In function ‘QDateTime mixxx::localDateTimeFromUtc(const QDateTime&)’:
mixxx/src/util/datetime.h:16:51: error: ‘QDateTime::QDateTime(QDate, QTime, Qt::TimeSpec, int)’ is deprecated:
Pass QTimeZone instead [-Werror=deprecated-declarations]
16 | return QDateTime(dt.date(), dt.time(), Qt::UTC).toLocalTime();
| ^
In file included from /usr/include/qt6/QtCore/QDateTime:1,
from mixxx/src/util/fileinfo.h:5,
from mixxx/src/util/fileaccess.h:3,
from mixxx/src/library/browse/browsethread.h:14,
from mixxx/src/library/browse/browsethread.cpp:1:
/usr/include/qt6/QtCore/qdatetime.h:359:5: note: declared here
359 | QDateTime(QDate date, QTime time, Qt::TimeSpec spec, int offsetSeconds = 0);
| ^~~~~~~~~
cc1plus: all warnings being treated as errors
Fixes warnings such as:
mixxx/src/skin/legacy/legacyskinparser.cpp: In static member function ‘static QDomE
lement LegacySkinParser::openSkin(const QString&)’:
mixxx/src/skin/legacy/legacyskinparser.cpp:237:25: error: ‘bool QDomDocument::setCo
ntent(QIODevice*, QString*, int*, int*)’ is deprecated: Use the overload returning ParseResult instead
. [-Werror=deprecated-declarations]
237 | if (!skin.setContent(&skinXmlFile,&errorMessage,&errorLine,&errorColumn)) {
| ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/qt6/QtXml/QDomElement:1,
from mixxx/src/skin/legacy/legacyskinparser.h:3,
from mixxx/src/skin/legacy/legacyskinparser.cpp:1:
/usr/include/qt6/QtXml/qdom.h:330:10: note: declared here
330 | bool setContent(QIODevice *dev, QString *errorMsg, int *errorLine = nullptr, int *errorCol
umn = nullptr);
| ^~~~~~~~~~
Holzhaus
force-pushed
the
qt6.7-deprecated-decls
branch
from
eec9ea4
to
768c022
Compare
Swiftb0y
approved these changes
Nov 8, 2024
|
CI is failing in 2.5. Not because of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.