-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update djing_with_mixxx.rst - autodj decks orientation #680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for starting this!
I made some proposals based on your draft (might look like a complete rewrite, we obviously have different styles of writing ; ) in order to improve the structure and reduce the wall of text a bit.
No problem, it's a kind of personal evolution. |
Are you motivated to update the screenshot, too? |
I think we should move the new text below the existing paragraph
so the crossafder explanation is continuation of that. What do you think? |
I think you already know my motivation:-) |
I added a screenshot, if you like it we can remove the old one. |
ignore... they are not related to the changes of this PR. Thanks for the screenshot, but we don't the illustration (it's not translatable), just a simple view of the Auto DJ pane is sufficient. Can you revert to the clean view?
Thank you, this looks good now IMO! |
I guess you mean: no writing on the image? |
Yes & no, I meant the clean screenshot (no annotations) of only the AutoDJ pane (no decks, no mixer). |
ronso, do I have to do something more? |
This looks good now, thank you. |
Could you please crop the screenshot accordingly? |
done |
Uaah, not sure what happened. |
Hm, I think the issue is that your branch is named like a remote branch (2.4) and not something like autodj-update. Could you please try to open a PR from your 2.4 branch? Sorry for the inconvenience! |
Hi ronso, is there a spell of the hithubghosts involved? :-) |
I'll try to explain: I'll simply push the all-in-one commit to mixxxdj/manual. |
All good ronso0, I trust you completely. Sorry if I did something wrong with the naming. |
Update djing_with_mixxx.rst - autodj decks orientation
Preview: https://deploy-preview-680--mixxx-manual.netlify.app/chapters/djing_with_mixxx#auto-dj