Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xone K2] Fix formatting #580

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[Xone K2] Fix formatting #580

merged 1 commit into from
Sep 21, 2023

Conversation

sven-frotscher
Copy link
Contributor

The nested list items weren't indented.

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this LGTM

@ronso0
Copy link
Member

ronso0 commented Sep 20, 2023

Thank you for this contribution!

Updates should go to the branch that corresponds to the mixxx branch that contains the mapping.
In this case the mapping itself was last changed 3 years ago, so it's definitely in Mixxx 2.3.
Please rebase onto 2.3, force-push. I already changed the target branch here, hence those ~150 unrelated commits.

Rebasing this single commit should be as easy as
git rebase -i [mixxx remote]/2.3 where [mixxx-remote] is the name you gave to the mixxx remote repo.
while you're at it, please rephrase the commit message so we know it's about the Xone K2.
If you have any questions don't hesitate to ask.

@ronso0 ronso0 changed the base branch from main to 2.3 September 20, 2023 11:34
@sven-frotscher
Copy link
Contributor Author

Like this? It required some jumping through hoops since I originally made the edit on GitHub, not locally.

@ronso0
Copy link
Member

ronso0 commented Sep 21, 2023

Yup, looks good. Thank you!

@ronso0 ronso0 merged commit d001209 into mixxxdj:2.3 Sep 21, 2023
7 of 8 checks passed
@sven-frotscher sven-frotscher deleted the patch-1 branch September 27, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants