Pioneer DDJ-FLX4: Added controller mapping documentation #534
Conversation
|
Not sure what should be done... The errors reported by the link checker are for files not modified by this PR... |
The link issues are fixed in the 2.3 branch now. To get these fixes, call: |
|
Just pushed a new version with a new mapping for the FX buttons, inline with the modification done in the DDJ-400 mapping |
|
Retargetted at 2.4 |
|
Looks like rebase went wrong, this |
|
I actually avoided using rebase to avoid problems (I had to look for retarget procedure in internet;..), so I forced content of 2.4 into my branch and reapplied my commits... (sorry if it is uselessly complex and if my commit message was not good...) The resulting branch compared to the 2.4 is indeed only my 7 added files ! Is it not good like that ? (I was busy doing the same for the mapping itself...) |
|
Well, here it's 23 commits: 8 about the FLX4 plus merge commits and unrelated stuff. I don't see any actual inline code review that might get detached during rebase, so just go ahead and rebase I'd say 🤷♂️ |
|
OK... tried again, I hope I did not make a mess! |
|
And removed the brands/logos as requested |
|
broken checks are not linked to this PR... |
|
Okay, great. It's just 5 commits now (compared to 8 I saw before), did you double-check the chapter includes everything you added earlier? |
|
I just realized the page numbers pointing to the manufacturer's manual were not valid anymore, I updated them. Now just waiting for the mapping itself to be merged :-) |
Don't worry, we usually wait until both the mapping itself and the corresponding documentation in the manual are ready and then merge both at the same time 😄 |
| Pad Modes | ||
| ^^^^^^^^^ | ||
|
|
||
| The pad mode buttons change between different modes in which the performance pads operate. The main | ||
| pad modes described below are similar to those found in rekordbox. | ||
|
|
||
| .. note:: The secondary pad modes described in the manufacturer's manual | ||
| (:hwlabel:`KEYBOARD` :hwlabel:`PAD FX1` :hwlabel:`PAD FX2` and | ||
| :hwlabel:`KEYSHIFT`) are not currently implemented by this | ||
| mapping. | ||
|
|
||
| Hot Cue Mode |
There was a problem hiding this comment.
Could you look into using different heading levels here (and probably throughout the entire page)?
Currently Pad Modes and each mode heading are the same level.
Maybe numbering works, too.
| No. Control Function | ||
| ======== ================================================== ========================================== | ||
| 1 :hwlabel:`LOAD` buttons Load track selected in library into deck. | ||
| 2 Rotary Selector Press to toggle focus between the library sidebar and associated panels. Turn to move focus up or down. |
There was a problem hiding this comment.
| 2 Rotary Selector Press to toggle focus between the library sidebar and associated panels. Turn to move focus up or down. | |
| 2 Rotary Selector Press to move focus between the library sidebar, search bar and tracks view (Shift+press to move focus backwards). Turn to move selection up or down. |
|
Looks like I was too slow with my review... @Robert904 Do you mind taking a look at my suggestions nonetheless and maybe implement them in a follow-up PR? |
|
Sorry merging prematurely... 🫣 |
|
@Swiftb0y don't worry, I started this review yesterday and didn't manage to finalize it until now. maybe should have posted it chunk by chunk. |
Documentation for the proposed mapping for Pioneer controller DDJ-FLX4.
Preview:
https://deploy-preview-534--mixxx-manual.netlify.app/hardware/controllers/pioneer_ddj_flx4
PR for the mapping is mixxxdj/mixxx#11245