-
Notifications
You must be signed in to change notification settings - Fork 10
Fix bug related to spaces in the project path #149
base: master
Are you sure you want to change the base?
Conversation
Thanks for the contribution! If you don't mind, could you actually grab a package like shell quote and stick that in there? It's more of an edge case, but this would also break if someone used quotation marks in their path; shell-quote should fix it permanently :) |
Oh, you're right. I didn't think about that possibility. Also, (sorry I'm still getting used to these commit standards...) how should the title/body of the commit be? |
The commit you have looks good. Don't worry about it too much though, we can squash merge and fix it up. |
Just pushed the commit using |
Whoops. The current code won't work for non-spaced paths (lol). I'm working on it to make it run. (I'm probably going to implement the escape function inside the script instead of using external modules) |
I would recommend against that, shell escaping is surprisingly hard (as indicated by the number of commits and issues in the shell-quote repo!) Webpack shouldn't really care about double quotes in particular, the OS' shell should itself be the one delimiting arguments. E.g. in your basic C program, your main function can take arguments; parsing those is not part of the C standard library or compiler, it's the OS. What happens if you pass that whole array |
Closes #141