Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.6.0 dev #52

Merged
merged 158 commits into from
Jun 21, 2024
Merged

0.6.0 dev #52

merged 158 commits into from
Jun 21, 2024

Conversation

mivanit
Copy link
Owner

@mivanit mivanit commented Jun 17, 2024 •
edited
Loading

  • add support and CI checks for python >=3.8 (Previously only 3.10, 3.11 were supported)
    • this mostly consisted of messing with a lot of type annotations and adding from __future__ import annotations in a number of places
  • added validate_type function
    • make SerializableDatclass actually do type validation
  • improvements to SerializableDataclass and related functions
    • much better docs and comments
    • move SerializableField and serializable_field to their own file
    • resolve clearer alternative to loading_fn #40 by adding deserialize_fn to SerializableField
    • moved array_safe_eq and dc_eq to muutils.json_serialize.util
    • added array_b64_meta mode to muutils.json_serialize.array, works pretty much the same as existing array_hex_meta but should take less space
  • added ErrorMode enum
    • special .process() method which takes a message (and optionally classes for warnings and errors, and an except_from parameter) and decides whether to throw warning, exception, or do nothing
    • switched error mode handling to this across the package
  • switch to ruff for formatting and linting
  • add cli interface to muutils.sys_info
  • added sanitize_name function with sanitize_fname and sanitize_identifier as special cases
    • see muutils.misc
  • big changes and improvements to CI/makefile
    • uv now used to install deps in CI, separate job for checking poetry.lock consistency
    • makefile recipes reworked, and major changes to internals. make help for more info
    • added many comments to the makefile
  • many other small fixes and changes, including a large number of new tests

@mivanit
try running CI for python >=3.8
26c28d5
@mivanit
update pyproject.toml for python >=3.8
cc768c7
@mivanit
fix some deps
305a081
@mivanit
add py 3.12 to tests
18c5786
@mivanit
some typing fixes
efe6b66
@mivanit
wip typing fixes
1a762a8
@mivanit
fix a bunch of type hints
df4a6c9
@mivanit
sanitize_name function, with wrappers for fnames and identifiers
f4724eb
@mivanit
tests for new sanitize_name and derived
fd2d413
@mivanit
some fixes
c68499d
@mivanit
wip
d50a38d
@mivanit
fix formatting
695aed1
@mivanit
fix mro
66c99b7
@mivanit
fix monotuple
5584855
@mivanit
added base64 array mode (similar to existing hex mode)
4be7274
@mivanit
remove py3.12 for now
4100cf4
@mivanit
run format
7c301c5
@mivanit
hacky fix for failing to get type hints in python 3.8
07cac42 
- cant get around `typing.get_type_hints` failing on `dict[str, int]` style types, event with `typing-extensions`
- added some warnings and error checks if the python version is old
- got confused by my own code but commented what I could
- added some TODO comments
- went down some rabbit holes, learned a lot about python :)
- that was an adventure
@mivanit
deleted test notebook
ce12d94 
it was junk, never should have been in the repo, but it's there in the commit history to remind me of what exactly goes wrong just in case
@mivanit
fix more warnings
80f8aaf
@mivanit
format
400bc2e
@mivanit
fixing some warnings
f366a11
@mivanit
NO WARNINGS
fa2839e
@mivanit
format
3be50f3
@mivanit
fix for not warning on python >=3.10
feb9b0e
@mivanit
fix kw_only args for py 3.9
2d8cde8
@mivanit
bump pytest dep
6a81a6d
@mivanit
wip
542a439
@mivanit
wip
a93e188
@mivanit
format
681e691
@mivanit mivanit changed the title attempting to add support for python >=3.8 0.6.0 dev Jun 21, 2024
@mivanit mivanit merged commit 0e46cf1 into main Jun 21, 2024
8 checks passed
@mivanit mivanit deleted the add-py38-compat branch June 21, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clearer alternative to loading_fn
1 participant
@mivanit