Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing CI and pytorch versions #41

Merged
merged 4 commits into from
Jul 24, 2023
Merged

fixing CI and pytorch versions #41

merged 4 commits into from
Jul 24, 2023

Conversation

mivanit
Copy link
Owner

@mivanit mivanit commented Jul 24, 2023

  • originally meant to make pytorch/numpy/jaxtyping optional requirements ("extras")
  • i thought that this would be a small fix, but the multitude of commits in main have shown that not to be the case :(
  • current status is that in CI the cuda version of pytorch gets installed, which then fails when we try to import torch in the tests because the CI environment does not have cuda. I am very stumped

@mivanit
Copy link
Owner Author

mivanit commented Jul 24, 2023

Probably noone but me will ever see this but I have been trying to get this fixed for /days/ and it is really nice to have it working :D

@mivanit mivanit merged commit 805548b into main Jul 24, 2023
4 checks passed
@mivanit mivanit deleted the fix-ci-pytorch branch July 24, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant