-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add symbolic link options #482
base: master
Are you sure you want to change the base?
Add symbolic link options #482
Conversation
- Add enable_symlink boolean option for read, extractall, and extract - Default to be True. It will be False in future. - Add dereference boolean option for write and writeall - SevenZipFile constructor option dereference is marked deprecated and will be removed in future version Signed-off-by: Hiroshi Miura <[email protected]>
97b90c6
to
b5edae5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should treat an argument dereferece
of SevenZipFile constructor as a default of write
and writeall
methods, and users can override it in each write call.
Use SevenZipFile argument dereference as default for extract methods
#636 related |
- use SevenZipFile constructor dereference option as default
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
- Fix a case when given fd is None for Worker.writestr
This modification changes the behavior of py7zr. When got symbolic link inside archive, previous versions are extract it as symbolic link but now py7zr requires EXPLICIT option to extract symbolic link. It is because, we need to update a manual document and put warning on README. |
Signed-off-by: Hiroshi Miura [email protected]