Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple small improvements #160

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Multiple small improvements #160

wants to merge 3 commits into from

Commits on Mar 12, 2024

  1. Fix bool/int inconsistency for TextArea property 

    As TextArea::m_selectable field is a bool, it makes sense for TextArea::is_selectable() and TextArea::set_selectable() methods to return and accept bool.
    @mkupchik
    mkupchik committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    37c4146 View commit details
    Browse the repository at this point in the history

  2. Remove duplicate code in TabWidgetBase::perform_layout() 

    It's enough to clear m_tab_offsets once in this context.
    @mkupchik
    mkupchik committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    05f063d View commit details
    Browse the repository at this point in the history

  3. Fix duplicate check in TextArea::draw() 

    TextArea::draw() checks there's a selected area before drawing highlighted background. However, there's a duplicate condition `m_selection_end != Vector2i(-1)` in this check, presumably due to a typo. Let's do this check properly, using the same rules as in TextArea::keyboard_event().
    @mkupchik
    mkupchik committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    40ff1f1 View commit details
    Browse the repository at this point in the history