Add support for reading and writing to AWS S3 buckets #746
Conversation
|
Did we update the documentation on the README? I don't see that. |
Some sites (such as GitHub) don't support HEAD on files.
aaronlippold
changed the title
|
This pull request has a conflict. Could you fix it @camdenmoors? |
| parsedURI = new URL(uri) | ||
| logger.debug(`Parsed URI: ${uri} - Protocol is ${parsedURI.protocol}`) | ||
| } catch { | ||
| return fs.readFileSync(uri, encoding) |
There was a problem hiding this comment.
Is this really the best place in our 'switch' statement to get the 'I am reading a file from the filesystem' case?
|
We seem to be missing unit tests |
|
This pull request has a conflict. Could you fix it @camdenmoors? |
1 similar comment
|
This pull request has a conflict. Could you fix it @camdenmoors? |
Signed-off-by: Charles Hu <[email protected]>
|
This pull request has a conflict. Could you fix it @camdenmoors? |
Signed-off-by: Charles Hu <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
This pull request has a conflict. Could you fix it @camdenmoors? |
4 similar comments
|
This pull request has a conflict. Could you fix it @camdenmoors? |
|
This pull request has a conflict. Could you fix it @camdenmoors? |
|
This pull request has a conflict. Could you fix it @camdenmoors? |
|
This pull request has a conflict. Could you fix it @camdenmoors? |
Adds support for reading and writing to S3