Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Export Support #1689

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

HTML Export Support #1689

wants to merge 19 commits into from

Conversation

charleshu-8
Copy link
Contributor

  • Add support for an hdf2html convert command to generate HTML exports via HTML export feature from HDF Converters

@charleshu-8
Initial converter
8fb223b 
Signed-off-by: Charles Hu <[email protected]>
@charleshu-8 charleshu-8 added the enhancement New feature or request label Aug 17, 2023
@charleshu-8 charleshu-8 self-assigned this Aug 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Amndeep7 Amndeep7 marked this pull request as ready for review December 20, 2023 06:49
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 20, 2023 •
edited
Loading

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Amndeep7 Amndeep7 added the ready-to-merge Used by mergify to identify if a PR is ready to merge into main. label Dec 20, 2023
Amndeep7
Amndeep7 requested changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@Amndeep7 Amndeep7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests (here and in hdf-converters), needs to be documented in the readme

@Amndeep7 Amndeep7 removed the ready-to-merge Used by mergify to identify if a PR is ready to merge into main. label Dec 20, 2023
@Amndeep7 Amndeep7 mentioned this pull request Mar 6, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@em-c-rod
Copy link
Contributor

em-c-rod commented Apr 1, 2024

Needs comments added in README

em-c-rod
em-c-rod reviewed Apr 1, 2024
View reviewed changes
src/commands/convert/hdf2html.ts Outdated
files.push({data, fileName, fileID})
}

const converter = await new Mapper(files, FileExportTypes.Administrator).toHTML('/html/')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add an input flag for report type rather than defaulting to Administrator?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

em-c-rod
em-c-rod reviewed Apr 1, 2024
View reviewed changes
tailwind.config.js Outdated
@@ -0,0 +1,31 @@
/** @type {import('tailwindcss').Config} */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unneeded imports

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HDF to HTML has been refactored to avoid needing tailwind on SAF CLI. Tailwind is all managed by hdf-converters's build system.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kemley76 kemley76 mentioned this pull request Jun 11, 2024
Closed
@kemley76
Copy link
Contributor

These changes are dependent on this Heimdall PR

@kemley76
Copy link
Contributor

Now dependent on only this heimdall PR

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 26, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kemley76 kemley76 mentioned this pull request Aug 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kemley76 kemley76 kemley76 left review comments

@em-c-rod em-c-rod em-c-rod left review comments

@Amndeep7 Amndeep7 Amndeep7 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@charleshu-8 charleshu-8

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charleshu-8 @em-c-rod @kemley76 @Amndeep7