CLRU added for git plugin #750
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
requested changes
Jan 3, 2025
| type GitRawCommitCache = Option<(PathBuf, ObjectId, Vec<RawCommit>)>; | ||
| type GitRawCommitCache = CLruCache<(PathBuf, ObjectId), Vec<RawCommit>>; | ||
| static CACHE: LazyLock<Mutex<GitRawCommitCache>> = | ||
| LazyLock::new(|| Mutex::new(CLruCache::new(NonZero::new(1).unwrap()))); |
There was a problem hiding this comment.
The point of this PR is to make the 1 you have here a configurable parameter
| @@ -4,6 +4,7 @@ use crate::data::*; | |||
|
|
|||
| use anyhow::Context; | |||
| use anyhow::Result; | |||
| use clru::CLruCache; | |||
There was a problem hiding this comment.
Is there a reason that the clru crate is better for this than lru? https://docs.rs/lru/latest/lru/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12/30 - The PR has changes to the
gitplugin that uses an LRU cache functionality. The configurability of the size of the cache would come after the #662 changes are pulled.