Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backoff_interval adjusted for MacOS #590

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

aamohd
Copy link
Contributor

@aamohd aamohd commented Nov 7, 2024

The backoff_interval was causing failures to run on MacOS with a Reached max spawn attempts for plugin... error. This fix increases the backoff_interval_micros value to allow enough time for a connection to made for the plugin.

Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One fix, otherwise looks good

hipcheck/src/plugin/manager.rs Outdated Show resolved Hide resolved
fix: include sleep_duration calculation
@aamohd aamohd force-pushed the aamohd/backoff-interval-fix branch from 86d8a96 to 3611070 Compare November 7, 2024 18:48
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aamohd aamohd merged commit f6598ab into main Nov 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants