fix: Fix injection logic for datetime and span #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of JSON pointer injection for datetime and span data was incorrect. In the prior implementation, the datetime or span data needed to be provided as an object with two fields: `field` and `data`, where `field` specifies the type to convert the `data` field into. The correct implementation is to simply try converting into one, then the other, and to then fail if neither succeeds. They have completely distinct string representations, so there is not a possibility of confusable conversion into the *wrong* type with this approach. In the future we can and should update this implementation to incorporate the JSON schema data on what type is intended. I believe confusion on the use of JSON schema here (which *does* use the `field`/`data` pattern described above, but in the _schema_ not the actual data) was the source of the original mistaken implementation. Signed-off-by: Andrew Lilley Brinker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of JSON pointer injection for datetime and span data was incorrect. In the prior implementation, the datetime or span data needed to be provided as an object with two fields:
fieldanddata, wherefieldspecifies the type to convert thedatafield into. The correct implementation is to simply try converting into one, then the other, and to then fail if neither succeeds. They have completely distinct string representations, so there is not a possibility of confusable conversion into the wrong type with this approach.In the future we can and should update this implementation to incorporate the JSON schema data on what type is intended. I believe confusion on the use of JSON schema here (which does use the
field/datapattern described above, but in the schema not the actual data) was the source of the original mistaken implementation.