Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (doc): Adds date and time information to Plugin RFD #448

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

mchernicoff
Copy link
Contributor

Adds information about using DateTime and Span plugin primitives and their operations to RFD4. Changes some internal documentation and testing to be more explicit about what kinds of Spans are allowed.

@mchernicoff mchernicoff added type: chore Clean up or management task. product: website Relates to the Hipcheck website product: project Relates to the project itself labels Sep 25, 2024
@mchernicoff mchernicoff added this to the 3.7.0 milestone Sep 25, 2024
@mchernicoff mchernicoff requested a review from a team September 25, 2024 15:26
@mchernicoff mchernicoff self-assigned this Sep 25, 2024
@mchernicoff mchernicoff requested review from cstepanian and removed request for a team September 25, 2024 15:26
@mchernicoff mchernicoff force-pushed the mchernicoff/datetime-rfd branch 2 times, most recently from e16cf5a to d7b5c42 Compare September 25, 2024 15:28
@mchernicoff mchernicoff changed the title doc: Adds date and time information to Plugin RFD chore (doc): Adds date and time information to Plugin RFD Sep 25, 2024
@j-lanson
Copy link
Collaborator

@alilleybrinker is this how the RFD system is designed to work? My understanding was that this would require a new RFD

@mchernicoff
Copy link
Contributor Author

You may be right. I wasn't sure since otherwise this RFD on the site would contain information that wasn't up to date anymore. But I guess that is allowed for RFD's, isn't it?

Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits to change, but otherwise looks good!

@j-lanson j-lanson merged commit e21fec4 into main Sep 27, 2024
10 checks passed
@alilleybrinker alilleybrinker deleted the mchernicoff/datetime-rfd branch November 5, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: project Relates to the project itself product: website Relates to the Hipcheck website type: chore Clean up or management task.
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants