feat: allow use of unknown arches through commandline #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
force-pushed
the
jlanson/allow-unknown-arch
branch
from
7ecabff
to
759baa5
Compare
j-lanson
force-pushed
the
jlanson/allow-unknown-arch
branch
from
759baa5
to
52f6ace
Compare
alilleybrinker
requested changes
Sep 23, 2024
j-lanson
force-pushed
the
jlanson/allow-unknown-arch
branch
from
52f6ace
to
d0197bf
Compare
alilleybrinker
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
SupportedArchwith anArchenum, which is further subdivided intoUnknown(String)and theKnownArchenum.Currently
DETECTED_ARCHisOption<KnownArch>, but we could expand it to be justArch, and try to get the target triple at compile time as a string to fill theArch::Unknownvariant. Without doing this, right now you'll be forced to specify--archon the command line even if you build and run on the same arch, assuming its not one of theKnownArchtypes.