feat: add --arch flag to hc check subcommand to allow detection override
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…detection override We had previously encountered problems with cross-compilation to niche-but-valid architectures, where the compile-time target detection would fail, causing `CURRENT_ARCH` to be `()` instead of a valid arch enum variant. We changed this field to be type `Option<SupportedArch>` and also support a user-provided `--arch` flag to override the detected arch at runtime if the user has good reason to do so.
j-lanson
added
type: enhancement
|
Thanks @j-lanson! I think this is part of what we need, and I'm happy to merge as-is. The part that's missing is expanding the |
alilleybrinker
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #415 .
We had previously encountered problems with cross-compilation to niche-but-valid architectures, where the compile-time target detection would fail, causing
CURRENT_ARCHto be()instead of a valid arch enum variant. We changed this field to be typeOption<SupportedArch>and also support a user-provided--archflag to override the detected arch at runtime if the user has good reason to do so.