Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Termainl.Started and Terminal.Stopped events #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added Termainl.Started and Terminal.Stopped events #7

wants to merge 2 commits into from

Conversation

candidtim
Copy link

Resolves #6

@candidtim
Added the Terminal.Stopped event
39275b1
@candidtim
Update dependency: textual>=0.14.0 (was >=0.8.0)
d0498d1 
Previous commit introduced custom messages Started and Stopped to
textual-terminal. `textual.message.Message` API had a breaking change in
0.14.0 which means that in order to be compatible with recent textual
versions the dependency on textual needs to be updated to 0.14.0 at
least.
@candidtim
Copy link
Author

As textual.message.Message API had a breaking change since 0.8.0 (previously declared minimal dependency version), I had o upgrade it to 0.14.0 (minimal compatible with the recent ones). However, I had to upgrade the poetry.lock too - please, feel free to let me know if you prefer having it upgraded differently. For the moment, it is upgraded to install textual==0.14.0 precisely, and the change is made with Poetry 1.7.1 (most recent one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A Message for when the command terminates
1 participant
@candidtim