-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Md/issue 2074 - xpro #2132
Md/issue 2074 - xpro #2132
Conversation
…ig. Removed a few un-needed vars.
…nto md/issue_2074
src/ol_infrastructure/applications/xpro/Pulumi.applications.xpro.CI.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good functionally. It might be good to have one of the developers working on xPro double check the values.
"MITXPRO_SECURE_SSL_REDIRECT": "True", | ||
"MITXPRO_USE_S3": "True", | ||
"NODE_MODULES_CACHE": "False", | ||
"OAUTH2_PROVIDER_ALLOWED_REDIRECT_URI_SCHEMES": "http,https,dccrequest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not specific to this PR, but wonder whether we should remove the http
scheme
What are the relevant tickets?
#2074 - xpro
Description (What does it do?)
This sets up management of the heroku xpro config vars to be done by pulumi rather than the salt stack.
Additional Context
This is the final redacted diff between the config currently in heroku and what this code will produce.
AWS Creds are expected
DB creds are expected
HUBSPOT_API_KEY
is deprecated and is nowMITOL_HUBSPOT_API_PRIVATE_TOKEN
New Relic and RedisCloud comes from heroku add-ons.
XPRO_*
are all deprecated: mitodl/mitxpro#2033