fix null program_num_required_courses on mitxonline series program #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeglova
approved these changes
Jan 3, 2024
rachellougee
deleted the
961-blank-program_num_required_courses-in-int__mitxonline__program_requirements-for-new-series-program
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
#961
Description (What does it do?)
Fixing bug on nulls when doing math on addition: 1 + NULL = NULL, which resulted null in program_num_required_courses for programs that only contain required courses. e.g. program_id=4,5,6,7,8,9
This bug also blocked a few downstream models (e.g. int__mitxonline__courserunenrollments) from being updated due to test failure.
How can this be tested?
test should pass
should have correct required course populated