Fix ckeditor console error #1633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1633 +/- ##
==========================================
- Coverage 89.14% 89.13% -0.01%
==========================================
Files 240 240
Lines 10194 10191 -3
Branches 1720 1721 +1
==========================================
- Hits 9087 9084 -3
Misses 963 963
Partials 144 144
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -20,7 +19,7 @@ export default function configureStore(initialState?: ReduxState) { | |||
| let createStoreWithMiddleware | |||
| if (process.env.NODE_ENV !== "production" && !global._testing) { | |||
| createStoreWithMiddleware = compose( | |||
| applyMiddleware(...COMMON_MIDDLEWARE, createLogger()), | |||
There was a problem hiding this comment.
I've always found our redux logging annoying and not helpful...it just clutters the dev console. In general, the same information is available in redux dev tools (chrome; firefox
It was sufficiently annoying while debugging this issue that I just got rid of it, and I think that should be a permanent change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Flight checklist
What are the relevant tickets?
#1632
What's this PR do?
How should this be manually tested?