-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use git package; remove hardcoded baseurl #1310
Merged
ChristopherChudzicki
merged 1 commit into
cg/add-mit-open-login-button
from
cg-cc/add-mit-open-login-button
Feb 6, 2024
Merged
use git package; remove hardcoded baseurl #1310
ChristopherChudzicki
merged 1 commit into
cg/add-mit-open-login-button
from
cg-cc/add-mit-open-login-button
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -113,7 +113,7 @@ | |||
"lodash.uppercase": "^4.3.0", | |||
"mathjax": "^3.2.2", | |||
"mini-css-extract-plugin": "^2.6.1", | |||
"mit-open-login-button": "/home/gumaerc/Code/mit-open-login-button", | |||
"mit-open-login-button": "https://github.com/mitodl/mit-open-login-button.git", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can also append #branch-name-or-tag
gumaerc
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
1bb720f
into
cg/add-mit-open-login-button
2 of 5 checks passed
gumaerc
pushed a commit
that referenced
this pull request
Feb 8, 2024
gumaerc
pushed a commit
that referenced
this pull request
Feb 12, 2024
gumaerc
pushed a commit
that referenced
this pull request
Feb 16, 2024
gumaerc
pushed a commit
that referenced
this pull request
Mar 4, 2024
gumaerc
pushed a commit
that referenced
this pull request
Mar 7, 2024
gumaerc
pushed a commit
that referenced
this pull request
Apr 26, 2024
gumaerc
pushed a commit
that referenced
this pull request
May 1, 2024
gumaerc
pushed a commit
that referenced
this pull request
May 18, 2024
gumaerc
pushed a commit
that referenced
this pull request
May 28, 2024
gumaerc
pushed a commit
that referenced
this pull request
Jun 18, 2024
gumaerc
pushed a commit
that referenced
this pull request
Jun 27, 2024
gumaerc
pushed a commit
that referenced
this pull request
Jul 8, 2024
gumaerc
pushed a commit
that referenced
this pull request
Jul 30, 2024
gumaerc
pushed a commit
that referenced
this pull request
Aug 13, 2024
gumaerc
pushed a commit
that referenced
this pull request
Sep 4, 2024
gumaerc
pushed a commit
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few small changes to
cg/add-mit-open-login-button
:mit-open-login-button
from git rather than local.