Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use git package; remove hardcoded baseurl #1310

Conversation

ChristopherChudzicki
Copy link
Contributor

This PR makes a few small changes to cg/add-mit-open-login-button:

  • Removes hard-coded MIT Open baseurl
  • Installs mit-open-login-button from git rather than local.
    • Local might still be easier and useful for development, but git is definitely easier for sharing with others.

@@ -113,7 +113,7 @@
"lodash.uppercase": "^4.3.0",
"mathjax": "^3.2.2",
"mini-css-extract-plugin": "^2.6.1",
"mit-open-login-button": "/home/gumaerc/Code/mit-open-login-button",
"mit-open-login-button": "https://github.com/mitodl/mit-open-login-button.git",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also append #branch-name-or-tag

Copy link
Collaborator

@gumaerc gumaerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristopherChudzicki ChristopherChudzicki merged commit 1bb720f into cg/add-mit-open-login-button Feb 6, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants