fix non-credit filter

[abeglova]

What are the relevant tickets?

None.

Selecting 'Non-Credit' at https://ocw.mit.edu/search/ does not work. This fixes the issue

Description (What does it do?)

We have parameter validation for the ocw search. Unfortunately, the parameter validation needs to be updated when we update the results from the api.

How can this be tested?

Set
SEARCH_API_URL=https://open.mit.edu/api/v0/search/
Run yarn start www
Turn CORS off in your browser
Go to http://localhost:3000/search/

Verify that you can select non-credit

Additional Context

Needing to manually update the possible parameters every time they change isn't great.

Once ocw is migrated to the new search api and mitodl/mit-learn#269 is implemented we can get the possible parameters from the client that will be created by mitodl/mit-learn#269

[github-actions]

Netlify Deployments:
www: https://ocw-hugo-themes-www-pr-1301--ocw-next.netlify.app/
Course v2: https://ocw-hugo-themes-course-v2-pr-1301--ocw-next.netlify.app/

[github-actions]

Device	URL
mobile	https://ocw-hugo-themes-www-pr-1301--ocw-next.netlify.app/

Device	URL
mobile	https://ocw-hugo-themes-www-pr-1301--ocw-next.netlify.app/search/

Device	URL
mobile	https://ocw-hugo-themes-course-v2-pr-1301--ocw-next.netlify.app/

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

[gumaerc]

👍 LGTM

Although, it's worth noting that I had to set some other env variables locally to get this to work. STATIC_API_BASE_URL, RESOURCE_BASE_URL and SITEMAP_DOMAIN need to be set to prod (https://ocw.mit.edu) if you are hitting prod search. Without this, the page would simply refresh upon selecting Non-Credit and the facet would not be selected. I'm not sure which of the vars made the difference, likely either STATIC_API_BASE_URL or RESOURCE_BASE_URL.

[ibrahimjaved12]

Thanks for fixing this! @abeglova
I had changed Non Credit to Non-Credit in ocw-hugo-projects, but I wasn't aware that there was a coupling of this in ocw-hugo-themes.