feat: update social links #1295
Conversation
|
Netlify Deployments: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
| Device | URL |
|---|---|
| mobile | https://ocw-hugo-themes-www-pr-1295--ocw-next.netlify.app/ |
| Device | URL |
|---|---|
| mobile | https://ocw-hugo-themes-www-pr-1295--ocw-next.netlify.app/search/ |
| Device | URL |
|---|---|
| mobile | https://ocw-hugo-themes-course-v2-pr-1295--ocw-next.netlify.app/ |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
| .locator(".footer-main-content") | ||
| .getByRole("link", { name, exact: true }) | ||
| await expect(link).toBeVisible() | ||
| await expect(link).toHaveAttribute("href", url) |
There was a problem hiding this comment.
Originally, I simulated a click and ran assertions on the navigation (i.e. open tab's URL). However, these external links can have uncontrollable behaviors.
For instance, I can open the Instagram link locally without being signed in but, in GitHub Action runner, this URL redirects to the login screen.
For that reason, I have now placed an assertion on the href attribute. Feel free to suggest improvements.
| @@ -81,7 +81,7 @@ | |||
| </li> | |||
| <li> | |||
| <a class="img-link" href="https://twitter.com/MITOCW" target="_blank"> | |||
| <img class="footer-social-icon" src="{{ partial "get_asset_webpack_url.html" "images/Twitter.png" }}" alt="twitter" /> | |||
| <img class="footer-social-icon" src="{{ partial "get_asset_webpack_url.html" "images/x-formerly-twitter-black.png" }}" alt="twitter" /> | |||
There was a problem hiding this comment.
I wonder if the alt text should be "x" or "x (formerly twitter)"?
🤢
There was a problem hiding this comment.
Looks good to me! (Agree with @ChristopherChudzicki's suggestion above).
|
The www build issue blocks this PR. https://www.ocw-openmatters.org is still unreachable. |
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/3298
Closes https://github.com/mitodl/hq/issues/3195
Description (What does it do?)
This PR:
STAY CONNECTED WITH OCWcard.Screenshots (if appropriate):
How can this be tested?
ocw-hugo-themesdirectory.hussaintaj/3298-new-social-iconsSTAY CONNECTED WITH OCWnear the bottom.