playwright base url override #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Netlify Deployments: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
| Device | URL |
|---|---|
| mobile | https://ocw-hugo-themes-www-pr-1280--ocw-next.netlify.app/ |
| Device | URL |
|---|---|
| mobile | https://ocw-hugo-themes-www-pr-1280--ocw-next.netlify.app/search/ |
| Device | URL |
|---|---|
| mobile | https://ocw-hugo-themes-course-v2-pr-1280--ocw-next.netlify.app/ |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
gumaerc
force-pushed
the
cg/playwright-external-site
branch
from
430eb70 to
14ac2e2
Compare
gumaerc
force-pushed
the
cg/playwright-external-site
branch
from
32b9ef3 to
1d69dec
Compare
…ing using a URL object
…n't using yarn test:e2e externally anyway
…ison from the target site
…s at the root, and use the href property for the URL
…son ahead of time
gumaerc
force-pushed
the
cg/playwright-external-site
branch
from
f048d58 to
0e919be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes #1285
Description (What does it do?)
This PR looks at a new env variable,
PLAYWRIGHT_BASE_URL, for a base URL to run Playwright tests against. If this variable is set, none of the steps inglobal-setup.tsare performed. Playwright proceeds to run its tests targeting the site denoted byPLAYWRIGHT_BASE_URL.How can this be tested?
This PR will mostly be tested as part of mitodl/ocw-studio#2018, although you should be able to still run
yarn test:e2elocally and everything should still function. Github Actions end to end tests should also still pass.