Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve API performance #3106

Merged
merged 1 commit into from
Aug 23, 2024
Merged

perf: improve API performance #3106

merged 1 commit into from
Aug 23, 2024

Conversation

asadali145
Copy link
Contributor

@asadali145 asadali145 commented Aug 21, 2024

What are the relevant tickets?

None

Description (What does it do?)

Improves API performance for courses, programs, and course_runs API.

Screenshots (if appropriate):

Before:

Screenshot 2024-08-22 at 10 55 43 AM
Screenshot 2024-08-22 at 10 56 19 AM
Screenshot 2024-08-22 at 10 57 31 AM

After

Screenshot 2024-08-22 at 11 01 02 AM
Screenshot 2024-08-22 at 11 01 33 AM
Screenshot 2024-08-22 at 11 01 53 AM

How can this be tested?

  • Verify the API Data has no changes.

Additional Context

There are still a few N+1 queries in courses and the course runs API due to the CMS Pages like CertificatePage and FacultyMembersPage. We cannot do anything simple to avoid those queries as there are no relational mappings.

Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@asadali145 asadali145 merged commit 4962713 into master Aug 23, 2024
7 checks passed
@asadali145 asadali145 deleted the asad/improve-ap-perf branch August 23, 2024 11:05
@odlbot odlbot mentioned this pull request Aug 27, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants