Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hybrid format option for courseware page #3105

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

asadali145
Copy link
Contributor

@asadali145 asadali145 commented Aug 21, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5210

Description (What does it do?)

Adds a new option for courseware format.

Screenshots (if appropriate):

Screenshot 2024-08-21 at 3 16 57 PM Screenshot 2024-08-21 at 3 19 49 PM

How can this be tested?

  • Verify that the courseware pages in CMS have a new option Hybrid in the format dropdown.
  • Verify that the format is visible on the product detail page.
  • Verify that the format is correct in the API, api/courses/, api/programs/

Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 . Based on https://github.com/mitodl/hq/issues/5210#issuecomment-2288603514 I believe nothing should break in MIT Learn. But, we should keep them informed that the xPRO APIs will have a new type of format value.

@asadali145 asadali145 merged commit 231dba6 into master Aug 23, 2024
7 checks passed
@asadali145 asadali145 deleted the asad/add-hybrid-format branch August 23, 2024 09:40
@odlbot odlbot mentioned this pull request Aug 27, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants