Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add course and program availability in APIs #3094

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

arslanashraf7
Copy link
Contributor

@arslanashraf7 arslanashraf7 commented Aug 8, 2024

What are the relevant tickets?

https://github.com/mitodl/hq/issues/4953

Description (What does it do?)

Adds the availability field in /courses and /programs APIs
Currently, We just send a hard-coded value because the calculation of the anytime value of availability is not possible in xPRO

How can this be tested?

  • Create a couple of courses and programs
  • Shift to this branch
  • Check the responses of /api/courses and /api/programs and they should have an availability field in the response
  • Check other APIs are not affected e.g. /api/products

@odlbot odlbot temporarily deployed to xpro-ci-pr-3094 August 8, 2024 13:34 Inactive
@odlbot odlbot temporarily deployed to xpro-ci-pr-3094 August 8, 2024 14:15 Inactive
@arslanashraf7 arslanashraf7 marked this pull request as ready for review August 8, 2024 14:23
Copy link
Contributor

@asadali145 asadali145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asadali145 asadali145 self-assigned this Aug 8, 2024
@asadali145 asadali145 merged commit 4488976 into master Aug 8, 2024
7 checks passed
@asadali145 asadali145 deleted the arslan/4953-add-availability branch August 8, 2024 14:46
@odlbot odlbot mentioned this pull request Aug 8, 2024
5 tasks
arslanashraf7 added a commit that referenced this pull request Aug 8, 2024
@odlbot odlbot mentioned this pull request Aug 8, 2024
6 tasks
arslanashraf7 added a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants