fix flaky test ordering #2427
Merged
fix flaky test ordering #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
rachellougee
approved these changes
Oct 24, 2024
| assert set(Product.objects.all().order_by("id")) == set(active_products) | ||
| assert set(Product.all_objects.all().order_by("id")) == set( | ||
| inactive_products + active_products | ||
| ) |
There was a problem hiding this comment.
This works but I think if we are ordering the Product.objects.all().order_by("id") then the list makes sense. Take it or leave it
assert list(Product.objects.all().order_by("id")) == list(active_products)
assert list(Product.all_objects.all().order_by("id")) == list(
inactive_products + active_products
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
NA
Description (What does it do?)
Fixes a flaky test that has delayed deployments. The fix is done by ordering the items in the unit test to ensure that the lists are compared equally.
How can this be tested?
Tests should pass.