Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add css in for visual focus on modal buttons #2053

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

JenniWhitman
Copy link
Contributor

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/2750

Description (What does it do?)

Adds visual focus to two elements mentioned above - the enroll now button and enroll free "button" (that looks like a link)

Screenshots (if appropriate):

Screenshot_2024-01-09_10-03-03
Screenshot_2024-01-09_10-03-22

How can this be tested?

Make sure your course has pricing set so it launches the modal. You should be able to tab through and it should highlight the various elements. These should be:

  • The X (previously worked and should still)
  • The Enroll Now button (did not have a border prior)
  • The Financial aid link (previously worked and should still - you will have to add a form to make this work OR - as I did - make a small change to the logic in the component to display it regardless)
  • The No thanks, I'll take it free "button"/link at the end (did not have a border prior)

Copy link
Contributor

@rachellougee rachellougee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The focus works on both course and program page.

@JenniWhitman JenniWhitman merged commit cddb650 into main Jan 10, 2024
3 checks passed
@JenniWhitman JenniWhitman deleted the jw/2750-visual-focus branch January 10, 2024 15:06
This was referenced Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants