Fix more tests

ecommerce/models.py

@@ -460,7 +460,7 @@ def _get_order_state(self):
         return self.order.state
 
     @state.on_success()
-    def _on_transition_success(self, descriptor, source, target, already_enrolled=False):
+    def _on_transition_success(self, descriptor, source, target, **kwargs):  # noqa: FBT002
         self.order.save()
 
     @state.transition(source=State.ANY, target=OrderStatus.CANCELED)
@@ -525,7 +525,7 @@ def refund(self, *, api_response_data: dict = None, **kwargs):  # noqa: RUF013
             reason=reason,
         )
 
-        send_order_refund_email.delay(self.id)
+        send_order_refund_email.delay(self.order.id)
 
         return refund_transaction
 

ecommerce/models_test.py

@@ -346,8 +346,8 @@ def test_create_transaction_with_no_transaction_id():
 
     with pytest.raises(ValidationError):  # noqa: PT012
         pending_order = OrderFactory.create(state=OrderStatus.PENDING)
-        pending_order.fulfill({})
-        pending_order.save()
+        pending_order_flow = pending_order.get_object_flow()
+        pending_order_flow.fulfill({})
     assert (
         Transaction.objects.filter(
             transaction_type="payment",
@@ -356,8 +356,9 @@ def test_create_transaction_with_no_transaction_id():
     )
 
     fulfilled_order = OrderFactory.create(state=OrderStatus.FULFILLED)
+    fulfilled_order_flow = fulfilled_order.get_object_flow()
     with pytest.raises(ValidationError):
-        fulfilled_order.refund(
+        fulfilled_order_flow.refund(
             api_response_data={},
             amount=fulfilled_order.total_price_paid,
             reason="Test refund",

ecommerce/tasks_test.py

@@ -53,8 +53,8 @@ def test_delayed_order_refund_sends_email(
 
     transaction_data = {"id": "refunded-transaction"}
     refund_amount = order.total_price_paid / 2
-
-    order.refund(
+    order_flow = order.get_order_flow()
+    order_flow.refund(
         api_response_data=transaction_data, amount=refund_amount, reason="testing"
     )