Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates required for Heroku Deploy to work out of box. #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

indagation
Copy link

I am working on some documentation for our course teams that want to use/create LTI Providers. I couldn't get the Heroku deploy working. I ended up figuring it out, but it required some updates to requirements and the python version. Also the two issues #36 and
#35 (comment)

Can both be resolved by simply quoting out the changes in config.py.

Also, edX is asking that we use lti_consumer as the advanced module. Presumably just to reduce confusion. lti still doesn't break, but it doesn't give you an option to add new lti components unless you have lti_consumer.

Also added a bit of wording in the readme to clarify the client key and client secret.

@pdpinch
Copy link
Member

pdpinch commented Feb 25, 2019

Oh wow, this repo doesn't have Travis or Coverage set up?

@indagation have you run the tests locally to see that things pass with your code changes? I'm actually wondering if you should split the docs and the code into separate PRs.

@mitodl/devops do you have an opinion about making the key optional? I actually can't remember why went that route -- I don't expect you know either though.

@indagation
Copy link
Author

indagation commented Feb 25, 2019 via email

@blarghmatey
Copy link
Member

I have no opinions on the key, but if needed I can do the digging necessary to form one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants