Skip to content

Commit

Permalink
removing check for live attribute (#1128)
Browse files Browse the repository at this point in the history
* removing check for live attribute

* fixing tests
  • Loading branch information
shanbady authored Jun 20, 2024
1 parent 8f3da74 commit fdaa66a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion learning_resources/etl/mitxonline.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ def _transform_course(course):
"published": bool(
parse_page_attribute(course, "page_url")
and parse_page_attribute(course, "live")
and course.get("live", False)
), # a course is only considered published if it has a page url
"professional": False,
"certification": has_certification,
Expand Down
2 changes: 0 additions & 2 deletions learning_resources/etl/mitxonline_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ def test_mitxonline_transform_programs(
"published": bool(
course_data.get("page", {}).get("page_url", None)
and course_data.get("page", {}).get("live", None)
and course_data.get("live", None)
),
"certification": True,
"certification_type": CertificationType.completion.name,
Expand Down Expand Up @@ -308,7 +307,6 @@ def test_mitxonline_transform_courses(settings, mock_mitxonline_courses_data):
"published": bool(
course_data.get("page", {}).get("page_url", None)
and course_data.get("page", {}).get("live", None)
and course_data.get("live", None)
),
"professional": False,
"certification": parse_certification(
Expand Down

0 comments on commit fdaa66a

Please sign in to comment.