Update React Query to v5 #2043
Merged
Update React Query to v5 #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,21 +24,21 @@ const learningPathKeys = { | |||
|
|
|||
| const learningPathQueries = { | |||
| list: (params: ListRequest) => | |||
| ({ | |||
| queryOptions({ | |||
There was a problem hiding this comment.
See https://tkdodo.eu/blog/the-query-options-api#queryoptions
This is just a TS helper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes #1940
Description (What does it do?)
Updates react query to v5
How can this be tested?
frontends/main/src/app/page.tsx, comment out one of the requests insideprefetch. When you reload the page, you should see a warning in JS console.frontends/main/src/app/page.tsx, add an extra useless request inside prefetch. (E.g.,learningResourceQueries.featured({ limit: 1 }). You should see a warning in JS console that a useless prefetch was made.