Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Learning Library CSV update #2014

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Open Learning Library CSV update #2014

wants to merge 2 commits into from

Conversation

mbertrand
Copy link
Member

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/6590

Description (What does it do?)

Updates the OLL CSV file, adding 3 courses

How can this be tested?

  • On the main branch, run ./manage.py backpopulate_oll_data. It should import 60 courses
  • On this branch, run it again, it should import 63 courses. The extra 3 courses should have readable_ids 21A.819.1x, 21A.819.2x, and 11.132x

@mbertrand mbertrand added the Needs Review An open Pull Request that is ready for review label Feb 5, 2025
@gumaerc gumaerc self-assigned this Feb 7, 2025
Copy link
Contributor

@gumaerc gumaerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good, although for what it's worth the readable ID's were prefixed with MITx like: MITx+21A.819.1x.

@mbertrand
Copy link
Member Author

Thanks. @gumaerc . @sovsey should the new readable ids in this csv be prefixed with MITx+ before merging?

@pdpinch
Copy link
Member

pdpinch commented Feb 10, 2025

I slacked Joe Martis. It seems like the URLs on OLL don't match the spreadsheet.

On OLL they are:
https://openlearninglibrary.mit.edu/courses/course-v1:MITx+21A.819.1x+3T2021/course/
https://openlearninglibrary.mit.edu/courses/course-v1:MITx+21A.819.2x+3T2021/course/
But in the spreadsheet you have them listed with an extra T:
MITxT+21A.819.1x
MITxT+21A.819.2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review An open Pull Request that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants