Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed runtime.txt and fixed poetry.lock #5349

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rhysyngsun
Copy link
Contributor

@rhysyngsun rhysyngsun commented Sep 21, 2023

What are the relevant tickets?

N/A

Description (What does it do?)

This fixes the heroku deployments that broke due to the switch to Poetry:

  • Removes runtime.txt since Heroku is erroring on it being present since Heroku just reads the runtime from pyproject.toml.
  • Ran poetry lock --no-update since Heroku is generating a warning for this
  • Added poetry lock --check to the CI actions so that we catch lockfile issues before they get merged.
  • Fixed indentation issue in ci.yaml.

How can this be tested?

  • Tests should pass

@rhysyngsun rhysyngsun force-pushed the nl/fix-heroku-deploys branch 3 times, most recently from a277455 to 1678071 Compare September 21, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant