Release 0.25.2 #366
Release 0.25.2 #366
Conversation
* fix: use context_key instead of course_id as it means the same thing (in the course context), and is provided as part of xblock.core * fix: work around errors preventing block preview in library context * `start` attribute does not exist in library context * catch errors for fields scoped outside "content" or "settings" * chore: bump package version
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @odlbot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the edx-sga repository to release version 0.25.2. The primary change involves replacing the Devstack environment with Tutor for integration tests. This includes modifications to the CI workflow to install and configure Tutor, along with changes to the script that runs the integration tests. Additionally, the version number in edx_sga/__init__.py and RELEASE.rst has been updated, and a minor fix addresses an issue with Content Libraries in edx_sga/sga.py.
Highlights
- Build System: Replaces Devstack with Tutor for running integration tests in the CI environment. This involves installing Tutor, setting it up with edx-platform, and modifying the integration test execution.
- Version Update: Updates the version number of the edx-sga package to 0.25.2 in
edx_sga/__init__.pyandRELEASE.rst. - Content Library Fix: Fixes an issue in
edx_sga/sga.pywhere the course ID was not correctly retrieved for blocks used in Content Libraries, and also addresses aNotImplementedErrorthat could occur when accessing fields in Library blocks.
Changelog
Click here to see the changelog
- .github/workflows/ci.yml
- Adds
edx_branchto the matrix to test against multiple Open edX releases. - Installs Tutor based on the
edx_branchbeing tested. - Sets up Tutor with a cloned edx-platform repository.
- Modifies the integration test execution to use Tutor instead of Devstack.
- Adds conditional logic to handle different Tutor directory names based on the
edx_branch.
- Adds
- RELEASE.rst
- Adds release notes for version 0.25.2, including a note about replacing Devstack with Tutor.
- edx_sga/init.py
- Updates the package version to 0.25.2.
- edx_sga/sga.py
- Modifies
block_course_idto return thecontext_keyinstead ofcourse_id, to handle Content Library blocks correctly. - Adds a try-except block in
update_staff_debug_contextto catchNotImplementedErrorwhen accessing fields in Library blocks.
- Modifies
- run_edx_integration_tests.sh
- Updates the script to source the Tutor virtual environment instead of the Devstack one.
- Updates the script to point to the edx-platform directory within the tutor environment.
- Adds the
--ds=lms.envs.testflag to the pytest command.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What is the name of the company that originally developed Tutor?
Click here for the answer
Tutor was originally developed by a company called Regalis.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request updates the version number in the RELEASE.rst file and the edx_sga/__init__.py file to 0.25.2. It also adds a release note indicating that Devstack has been replaced with Tutor. The changes seem straightforward and necessary for releasing a new version of the edx-sga XBlock.
Summary of Findings
Merge Readiness
The pull request appears to be ready for merging. The changes are simple and directly related to releasing a new version. I am unable to approve the pull request, and users should have others review and approve this code before merging.
Muhammad Arslan