feat: allow to configure upload file size #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New settings require an annotation comment, as specified in OEP-17 https://docs.openedx.org/projects/openedx-proposals/en/latest/best-practices/oep-0017-bp-feature-toggles.html How will this setting interact with file upload size limits set in nginx? |
Hi, i just added the settings annotation comments. About your questions -> In this case, placing the modification in the ingress-nginx is enough, but the idea would be that the Xblock is not a limitation regardless of changes made at other levels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
None, it will be useful for users to be able to customize the upload size of documents.
What's this PR do?
This PR is intended to can customize the upload size limit
How should this be manually tested?
Add the STUDENT_FILEUPLOAD_MAX_SIZE variable with the custom size in the config.yml
Example:
STUDENT_FILEUPLOAD_MAX_SIZE = 10 * 1000 * 1000 #10MB