Fix type and added some aria fields

mitodl · Jul 30, 2015 · 31673b1 · 31673b1
1 parent 4690834
commit 31673b1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/edx_sga/static/js/src/edx_sga.js b/edx_sga/static/js/src/edx_sga.js
@@ -106,8 +106,10 @@ function StaffGradedAssignmentXBlock(runtime, element) {
                     }
                 }
             });
-
             updateChangeEvent(fileUpload);
+            if (!_.isUndefined(state.error)) {
+                $(content).find('p.error').focus();
+            }
         }
 
         function renderStaffGrading(data) {
@@ -175,10 +177,13 @@ function StaffGradedAssignmentXBlock(runtime, element) {
                 event.preventDefault();
                 if (isNaN(score)) {
                     form.find('.error').html('<br/>Grade must be a number.');
+                    form.find('.error').focus();
                 } else if (score !== parseInt(score)) {
                     form.find('.error').html('<br/>Grade must be an integer.');
+                    form.find('.error').focus();
                 } else if (score < 0) {
                     form.find('.error').html('<br/>Grade must be positive.');
+                    form.find('.error').focus();
                 } else if (score > max_score) {
                     form.find('.error').html('<br/>Maximum score is ' + max_score);
                 } else {

diff --git a/edx_sga/templates/staff_graded_assignment/show.html b/edx_sga/templates/staff_graded_assignment/show.html
@@ -29,18 +29,18 @@
     <% if (upload_allowed) { %>
     <p>
       <% if (uploaded) { %>
-        <span id="upload_lable">{% trans "Upload a different file" %}</span>
+        <span id="upload_label">{% trans "Upload a different file" %}</span>
       <% } else { %>
-        <span id="upload_lable">{% trans "Upload your assignment" %}</span>
+        <span id="upload_label">{% trans "Upload your assignment" %}</span>
       <% } %>
-      <div class="upload" aria-describedby="upload_lable" aria-live="polite">
+      <div class="upload" aria-describedby="upload_label" role="alert" aria-live="assertive">
         <input class="fileupload" type="file" name="assignment"/>
         <button>Select a file</button>
       </div>
     </p>
     <% } %>
     <% if (error) { %>
-      <p class="error"><%= error %></p>
+      <p class="error" role="alert" aria-live="assertive" tabindex="1"><%= error %></p>
     <% } %>
   </script>
 
@@ -165,7 +165,7 @@
           <input id="submission_id-input" type="hidden" name="submission_id"/>
           <div>Grade for <span id="student-name"/></div>
           <div>Grade: <input id="grade-input" name="grade"/>
-            <span class="error"></span></div>
+            <span class="error" role="alert" aria-live="assertive" tabindex="1"></span></div>
           <div>Comment: <textarea id="comment-input" name="comment" rows="4"></textarea></div>
           <div>
             <button type="submit">{% trans "Submit" %}</button>